#16680: finch segfaults on terminal resize

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

#16680: finch segfaults on terminal resize

Pidgin
#16680: finch segfaults on terminal resize
---------------------+---------------------------------
 Reporter:  vvelox   |      Owner:  sadrul
     Type:  defect   |     Status:  new
Milestone:           |  Component:  finch (gnt/ncurses)
  Version:  2.10.11  |   Keywords:
---------------------+---------------------------------
 Terminal resizing worked with out issue in 2.10.10, but if you resize the
 terminal in 2.10.11 it segfaults.

 The tail of the trace of 2.10.11 when it happens is as below.

 {{{

 sigprocmask(SIG_SETMASK,SIGHUP|SIGINT|SIGQUIT|SIGILL|SIGTRAP|SIGABRT|SIGEMT|SIGFPE|SIGKILL|SIGBUS|SIGSEGV|SIGSYS|SIGPIPE|SIGALRM|SIGTERM|SIGURG|SIGSTOP|SIGTSTP|SIGCONT|SIGCHLD|SIGTTIN|SIGTTOU|SIGIO|SIGXCPU|SIGXFSZ|SIGVTALRM|SIGPROF|SIGWINCH|SIGINFO|SIGUSR1|SIGUSR2,0x0)
 = 0 (0x0)
 sigaction(SIGTSTP,{ SIG_IGN SA_RESTART ss_t },{ 0x8027d2ec0
 SA_RESTART|SA_SIGINFO ss_t }) = 0 (0x0)
 sigprocmask(SIG_SETMASK,0x0,0x0)                 = 0 (0x0)
 write(1,"\^[[10;2H\^[[32m   o convertfx -"...,323) = 323 (0x143)
 sigprocmask(SIG_SETMASK,SIGHUP|SIGINT|SIGQUIT|SIGILL|SIGTRAP|SIGABRT|SIGEMT|SIGFPE|SIGKILL|SIGBUS|SIGSEGV|SIGSYS|SIGPIPE|SIGALRM|SIGTERM|SIGURG|SIGSTOP|SIGTSTP|SIGCONT|SIGCHLD|SIGTTIN|SIGTTOU|SIGIO|SIGXCPU|SIGXFSZ|SIGVTALRM|SIGPROF|SIGWINCH|SIGINFO|SIGUSR1|SIGUSR2,0x0)
 = 0 (0x0)
 sigaction(SIGTSTP,{ 0x8027d2ec0 SA_RESTART|SA_SIGINFO ss_t },{ SIG_IGN
 SA_RESTART ss_t }) = 0 (0x0)
 sigprocmask(SIG_SETMASK,0x0,0x0)                 = 0 (0x0)
 clock_gettime(4,{4341757.019684483 })            = 0 (0x0)
 poll({3/POLLIN|POLLPRI 0/POLLIN|POLLPRI 0/0x0 5/POLLIN 7/POLLIN 22/POLLIN
 20/POLLIN 13/POLLIN 24/POLLIN 12/POLLIN 14/POLLIN 29/POLLIN 8/POLLIN
 11/POLLIN},14,2981) = 0 (0x0)
 clock_gettime(4,{4341760.002933262 })            = 0 (0x0)
 clock_gettime(4,{4341760.003166951 })            = 0 (0x0)
 poll({3/POLLIN|POLLPRI 0/POLLIN|POLLPRI 0/0x0 5/POLLIN 7/POLLIN 22/POLLIN
 20/POLLIN 13/POLLIN 24/POLLIN 12/POLLIN 14/POLLIN 29/POLLIN 8/POLLIN
 11/POLLIN},14,4997) ERR#4 'Interrupted system call'
 SIGNAL 20 (SIGCHLD)
 wait4(-1,{ EXITED,val=0 },WNOHANG,0x0)           = 4689 (0x1251)
 wait4(-1,{ SIGNALED,sig=SIGSEGV },WNOHANG,0x0)   = 0 (0x0)
 sigaction(SIGCHLD,{ 0x8020502b0 SA_RESTART ss_t },{ 0x8020502b0 SA_RESTART
 ss_t }) = 0 (0x0)
 sigreturn(0x7fffffffde70,0x7fffffffde28,0x7fffffffde08,0x0,0x107,0x18b5a)
 ERR#4 'Interrupted system call'
 clock_gettime(4,{4341760.797821230 })            = 0 (0x0)
 clock_gettime(4,{4341760.797982563 })            = 0 (0x0)
 poll({3/POLLIN|POLLPRI 0/POLLIN|POLLPRI 0/0x0 5/POLLIN 7/POLLIN 22/POLLIN
 20/POLLIN 13/POLLIN 24/POLLIN 12/POLLIN 14/POLLIN 29/POLLIN 8/POLLIN
 11/POLLIN},14,4203) = 0 (0x0)
 clock_gettime(4,{4341765.005902564 })            = 0 (0x0)
 clock_gettime(4,{4341765.006103986 })            = 0 (0x0)
 poll({3/POLLIN|POLLPRI 0/POLLIN|POLLPRI 0/0x0 5/POLLIN 7/POLLIN 22/POLLIN
 20/POLLIN 13/POLLIN 24/POLLIN 12/POLLIN 14/POLLIN 29/POLLIN 8/POLLIN
 11/POLLIN},14,4994) ERR#4 'Interrupted system call'
 SIGNAL 20 (SIGCHLD)
 wait4(-1,{ EXITED,val=0 },WNOHANG,0x0)           = 4687 (0x124f)
 wait4(-1,{ SIGNALED,sig=SIGSEGV },WNOHANG,0x0)   = 0 (0x0)
 sigaction(SIGCHLD,{ 0x8020502b0 SA_RESTART ss_t },{ 0x8020502b0 SA_RESTART
 ss_t }) = 0 (0x0)
 sigreturn(0x7fffffffde70,0x7fffffffde28,0x7fffffffde08,0x0,0x107,0x18b5a)
 ERR#4 'Interrupted system call'
 clock_gettime(4,{4341769.356288228 })            = 0 (0x0)
 clock_gettime(4,{4341769.356484761 })            = 0 (0x0)
 poll({3/POLLIN|POLLPRI 0/POLLIN|POLLPRI 0/0x0 5/POLLIN 7/POLLIN 22/POLLIN
 20/POLLIN 13/POLLIN 24/POLLIN 12/POLLIN 14/POLLIN 29/POLLIN 8/POLLIN
 11/POLLIN},14,644) ERR#4 'Interrupted system call'
 SIGNAL 20 (SIGCHLD)
 wait4(-1,{ EXITED,val=0 },WNOHANG,0x0)           = 4686 (0x124e)
 wait4(-1,{ SIGNALED,sig=SIGSEGV },WNOHANG,0x0)   = 0 (0x0)
 sigaction(SIGCHLD,{ 0x8020502b0 SA_RESTART ss_t },{ 0x8020502b0 SA_RESTART
 ss_t }) = 0 (0x0)
 sigreturn(0x7fffffffde70,0x7fffffffde28,0x7fffffffde08,0x0,0x107,0x18b5a)
 ERR#4 'Interrupted system call'
 clock_gettime(4,{4341769.960132571 })            = 0 (0x0)
 clock_gettime(4,{4341769.960316393 })            = 0 (0x0)
 poll({3/POLLIN|POLLPRI 0/POLLIN|POLLPRI 0/0x0 5/POLLIN 7/POLLIN 22/POLLIN
 20/POLLIN 13/POLLIN 24/POLLIN 12/POLLIN 14/POLLIN 29/POLLIN 8/POLLIN
 11/POLLIN},14,40) = 0 (0x0)
 clock_gettime(4,{4341770.003498977 })            = 0 (0x0)
 clock_gettime(4,{4341770.003619243 })            = 0 (0x0)
 poll({3/POLLIN|POLLPRI 0/POLLIN|POLLPRI 0/0x0 5/POLLIN 7/POLLIN 22/POLLIN
 20/POLLIN 13/POLLIN 24/POLLIN 12/POLLIN 14/POLLIN 29/POLLIN 8/POLLIN
 11/POLLIN},14,997) = 0 (0x0)
 clock_gettime(4,{4341771.006271815 })            = 0 (0x0)
 clock_gettime(13,{1433602926.000000000 })        = 0 (0x0)
 clock_gettime(13,{1433602926.000000000 })        = 0 (0x0)
 clock_gettime(4,{4341771.006723548 })            = 0 (0x0)
 poll({3/POLLIN|POLLPRI 0/POLLIN|POLLPRI 0/0x0 5/POLLIN 7/POLLIN 22/POLLIN
 20/POLLIN 13/POLLIN 24/POLLIN 12/POLLIN 14/POLLIN 29/POLLIN 8/POLLIN
 11/POLLIN},14,3994) ERR#4 'Interrupted system call'
 SIGNAL 28 (SIGWINCH)
 SIGNAL 11 (SIGSEGV)
 process exit, rval = 0




 }}}

--
Ticket URL: <https://developer.pidgin.im/ticket/16680>
Pidgin <https://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
[hidden email]
https://pidgin.im/cgi-bin/mailman/listinfo/tracker
Reply | Threaded
Open this post in threaded view
|

Re: #16680: finch segfaults on terminal resize

Pidgin
#16680: finch segfaults on terminal resize
---------------------+----------------------------------
 Reporter:  vvelox   |       Owner:  sadrul
     Type:  defect   |      Status:  new
Milestone:           |   Component:  finch (gnt/ncurses)
  Version:  2.10.11  |  Resolution:
 Keywords:           |
---------------------+----------------------------------

Comment (by marcus):

 I believe I have fixed this. Try the following patch:

 http://www.marcuscom.com/downloads/patch-finch_libgnt_gntmain.c

--
Ticket URL: <https://developer.pidgin.im/ticket/16680#comment:1>
Pidgin <https://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
[hidden email]
https://pidgin.im/cgi-bin/mailman/listinfo/tracker
Reply | Threaded
Open this post in threaded view
|

Re: #16680: finch segfaults on terminal resize

Pidgin
In reply to this post by Pidgin
#16680: finch segfaults on terminal resize
------------------------------------+----------------------------------
 Reporter:  vvelox                  |       Owner:  sadrul
     Type:  patch                   |      Status:  new
Milestone:  Patches Needing Review  |   Component:  finch (gnt/ncurses)
  Version:  2.10.11                 |  Resolution:
 Keywords:                          |
------------------------------------+----------------------------------
Changes (by Robby):

 * type:  defect => patch
 * milestone:   => Patches Needing Review


--
Ticket URL: <https://developer.pidgin.im/ticket/16680#comment:2>
Pidgin <https://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
[hidden email]
https://pidgin.im/cgi-bin/mailman/listinfo/tracker
Reply | Threaded
Open this post in threaded view
|

Re: #16680: finch segfaults on terminal resize

Pidgin
In reply to this post by Pidgin
#16680: finch segfaults on terminal resize
------------------------------------+----------------------------------
 Reporter:  vvelox                  |       Owner:  sadrul
     Type:  patch                   |      Status:  pending
Milestone:  Patches Needing Review  |   Component:  finch (gnt/ncurses)
  Version:  2.10.11                 |  Resolution:
 Keywords:                          |
------------------------------------+----------------------------------
Changes (by strangeways):

 * status:  new => pending


Comment:

 I can't reproduce this in 2.12.0, though the patch definitely makes sense
 for me. After all, the original SIGWINCH handler might have been set up
 with sigaction and thus require the extra arguments when chaining.

 Imported to Bitbucket : https://bitbucket.org/pidgin/main/pull-
 requests/269

--
Ticket URL: <https://developer.pidgin.im/ticket/16680#comment:3>
Pidgin <https://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
[hidden email]
https://pidgin.im/cgi-bin/mailman/listinfo/tracker
Reply | Threaded
Open this post in threaded view
|

Re: #16680: finch segfaults on terminal resize

Pidgin
In reply to this post by Pidgin
#16680: finch segfaults on terminal resize
---------------------+----------------------------------
 Reporter:  vvelox   |       Owner:  sadrul
     Type:  patch    |      Status:  closed
Milestone:  2.10.13  |   Component:  finch (gnt/ncurses)
  Version:  2.10.11  |  Resolution:  fixed
 Keywords:           |
---------------------+----------------------------------
Changes (by Gary Kramlich <grim@…>):

 * status:  pending => closed
 * resolution:   => fixed
 * milestone:  Patches Needing Review => 2.10.13


Comment:

 (In [859b15b1c817]):[[BR]]
 ChangeLog for PR #269 which fixes #16680

--
Ticket URL: <https://developer.pidgin.im/ticket/16680#comment:4>
Pidgin <https://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
[hidden email]
https://pidgin.im/cgi-bin/mailman/listinfo/tracker
Reply | Threaded
Open this post in threaded view
|

Re: #16680: finch segfaults on terminal resize

Pidgin
In reply to this post by Pidgin
#16680: finch segfaults on terminal resize
---------------------+----------------------------------
 Reporter:  vvelox   |       Owner:  sadrul
     Type:  patch    |      Status:  closed
Milestone:  2.12.1   |   Component:  finch (gnt/ncurses)
  Version:  2.10.11  |  Resolution:  fixed
 Keywords:           |
---------------------+----------------------------------
Changes (by Robby):

 * milestone:  2.10.13 => 2.12.1


--
Ticket URL: <https://developer.pidgin.im/ticket/16680#comment:5>
Pidgin <https://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
[hidden email]
https://pidgin.im/cgi-bin/mailman/listinfo/tracker