#16697: Replacing GTK Stock Items

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

#16697: Replacing GTK Stock Items

Pidgin
#16697: Replacing GTK Stock Items
---------------------+--------------------------
 Reporter:  mmcco    |      Owner:
     Type:  defect   |     Status:  new
Milestone:  3.0.0    |  Component:  pidgin (gtk)
  Version:  3.0.0hg  |   Keywords:
---------------------+--------------------------
 The current 3.0 tip gives a lot of warnings about deprecated GTK features,
 most or all of which seem to be related to Stock Items.

 Here's the announcement of their deprecation:

 https://mail.gnome.org/archives/gtk-devel-list/2013-July/msg00000.html

 It contains a link to a
 [https://docs.google.com/document/d/1KCVPoYQBqMbDP11tHPpjW6uaEHrvLUmcDPqKAppCY8o/pub
 Google Doc] that describes their rationale and in turn links to a
 [https://docs.google.com/spreadsheets/d/1HavJQRPpMuq-N0GoN1wJR-
 9KEGXpKy3-NEPpZZkUGJY/pub?output=html migration guide] (basically, an
 equivalent icon lookup table): They suggest that the changes should mostly
 be trivial.

 I'm going to start working on this. If a GTK veteran is interested, your
 help would be very much appreciated - I have very little GTK experience.

--
Ticket URL: <https://developer.pidgin.im/ticket/16697>
Pidgin <https://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
[hidden email]
https://pidgin.im/cgi-bin/mailman/listinfo/tracker
Reply | Threaded
Open this post in threaded view
|

Re: #16697: Replacing GTK Stock Items

Pidgin
#16697: Replacing GTK Stock Items
---------------------+---------------------------
 Reporter:  mmcco    |       Owner:
     Type:  defect   |      Status:  new
Milestone:  3.0.0    |   Component:  pidgin (gtk)
  Version:  3.0.0hg  |  Resolution:
 Keywords:           |
---------------------+---------------------------
Description changed by mmcco:

Old description:

> The current 3.0 tip gives a lot of warnings about deprecated GTK
> features, most or all of which seem to be related to Stock Items.
>
> Here's the announcement of their deprecation:
>
> https://mail.gnome.org/archives/gtk-devel-list/2013-July/msg00000.html
>
> It contains a link to a
> [https://docs.google.com/document/d/1KCVPoYQBqMbDP11tHPpjW6uaEHrvLUmcDPqKAppCY8o/pub
> Google Doc] that describes their rationale and in turn links to a
> [https://docs.google.com/spreadsheets/d/1HavJQRPpMuq-N0GoN1wJR-
> 9KEGXpKy3-NEPpZZkUGJY/pub?output=html migration guide] (basically, an
> equivalent icon lookup table): They suggest that the changes should
> mostly be trivial.
>
> I'm going to start working on this. If a GTK veteran is interested, your
> help would be very much appreciated - I have very little GTK experience.

New description:

 The current 3.0 tip gives a lot of warnings about deprecated GTK features,
 most or all of which seem to be related to Stock Items.

 Here's the announcement of their deprecation:

 https://mail.gnome.org/archives/gtk-devel-list/2013-July/msg00000.html

 It contains a link to a
 [https://docs.google.com/document/d/1KCVPoYQBqMbDP11tHPpjW6uaEHrvLUmcDPqKAppCY8o/pub
 Google Doc] that describes their rationale and in turn links to a
 [https://docs.google.com/spreadsheets/d/1HavJQRPpMuq-N0GoN1wJR-
 9KEGXpKy3-NEPpZZkUGJY/pub?output=html migration guide] (basically, an
 equivalent icon lookup table): They suggest that the changes should mostly
 be trivial.

 I'm going to start working on this.

--

--
Ticket URL: <https://developer.pidgin.im/ticket/16697#comment:1>
Pidgin <https://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
[hidden email]
https://pidgin.im/cgi-bin/mailman/listinfo/tracker
Reply | Threaded
Open this post in threaded view
|

Re: #16697: Replacing GTK Stock Items

Pidgin
In reply to this post by Pidgin
#16697: Replacing GTK Stock Items
---------------------+---------------------------
 Reporter:  mmcco    |       Owner:
     Type:  defect   |      Status:  new
Milestone:  3.0.0    |   Component:  pidgin (gtk)
  Version:  3.0.0hg  |  Resolution:
 Keywords:           |
---------------------+---------------------------

Comment (by mmcco):

 This means we're going to have to change our dialog API, which is defined
 through `pidgin_dialog_*` and `PIDGIN_STOCK_*`.

--
Ticket URL: <https://developer.pidgin.im/ticket/16697#comment:2>
Pidgin <https://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
[hidden email]
https://pidgin.im/cgi-bin/mailman/listinfo/tracker
Reply | Threaded
Open this post in threaded view
|

Re: #16697: Replacing GTK Stock Items

Pidgin
In reply to this post by Pidgin
#16697: Replacing GTK Stock Items
---------------------+---------------------------
 Reporter:  mmcco    |       Owner:
     Type:  defect   |      Status:  new
Milestone:  3.0.0    |   Component:  pidgin (gtk)
  Version:  3.0.0hg  |  Resolution:
 Keywords:           |
---------------------+---------------------------

Comment (by mmcco):

 I think I've taken care of most of this, with a few goofs along the way.

 Here are the relevant commits:

 * https://hg.pidgin.im/soc/2015/mmcc/main/rev/9b3a8112fa25
 * https://hg.pidgin.im/soc/2015/mmcc/main/rev/adf32a9a987d
 * https://hg.pidgin.im/soc/2015/mmcc/main/rev/5d4a86d3ccca
 * https://hg.pidgin.im/soc/2015/mmcc/main/rev/a06fddb594ed
 * https://hg.pidgin.im/soc/2015/mmcc/main/rev/9fa564642a58

 There are a few stock items left in the Pidgin^^Stock API that didn't have
 direct corollaries in the migration guide. Namely:

 * `GTK_STOCK_EDIT`
 * `GTK_STOCK_CANCEL`
 * `GTK_STOCK_APPLY`
 * `GTK_STOCK_DISCONNECT`

 See here:

 https://hg.pidgin.im/soc/2015/mmcc/main/rev/a06fddb594ed#l22.1

 ''(Ignore the `N_("_Executive")` line - that was a mistake fixed in the
 next commit.)''

 The GTK people suggest using `gtk3-icon-browser` to choose icons. Who
 thinks they can do a good job of that?

 Note also that this will break third-party plugin code previously written
 for the Pidgin^^Stock API.

--
Ticket URL: <https://developer.pidgin.im/ticket/16697#comment:3>
Pidgin <https://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
[hidden email]
https://pidgin.im/cgi-bin/mailman/listinfo/tracker
Reply | Threaded
Open this post in threaded view
|

Re: #16697: Replacing GTK Stock Items

Pidgin
In reply to this post by Pidgin
#16697: Replacing GTK Stock Items
---------------------+---------------------------
 Reporter:  mmcco    |       Owner:
     Type:  defect   |      Status:  new
Milestone:  3.0.0    |   Component:  pidgin (gtk)
  Version:  3.0.0hg  |  Resolution:
 Keywords:           |
---------------------+---------------------------

Comment (by mmcco):

 > The GTK people suggest using `gtk3-icon-browser` to choose icons. Who
 thinks they can do a good job of that?


 I just went ahead and did this:

 https://hg.pidgin.im/soc/2015/mmcc/main/rev/f4140f404d82

 Feel free to suggest corrections.

 I'm now working on converting images to icons where necessary.

--
Ticket URL: <https://developer.pidgin.im/ticket/16697#comment:4>
Pidgin <https://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
[hidden email]
https://pidgin.im/cgi-bin/mailman/listinfo/tracker
Reply | Threaded
Open this post in threaded view
|

Re: #16697: Replacing GTK Stock Items

Pidgin
In reply to this post by Pidgin
#16697: Replacing GTK Stock Items
---------------------+---------------------------
 Reporter:  mmcco    |       Owner:
     Type:  defect   |      Status:  new
Milestone:  3.0.0    |   Component:  pidgin (gtk)
  Version:  3.0.0hg  |  Resolution:
 Keywords:           |
---------------------+---------------------------

Comment (by salinasv):

 Related #856

--
Ticket URL: <https://developer.pidgin.im/ticket/16697#comment:5>
Pidgin <https://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
[hidden email]
https://pidgin.im/cgi-bin/mailman/listinfo/tracker
Reply | Threaded
Open this post in threaded view
|

Re: #16697: Replacing GTK Stock Items

Pidgin
In reply to this post by Pidgin
#16697: Replacing GTK Stock Items
---------------------+---------------------------
 Reporter:  mmcco    |       Owner:
     Type:  defect   |      Status:  new
Milestone:  3.0.0    |   Component:  pidgin (gtk)
  Version:  3.0.0hg  |  Resolution:
 Keywords:           |
---------------------+---------------------------

Comment (by Robby):

 See https://bitbucket.org/pidgin/main/pull-requests/234/and-updated-
 version-of-pr-169-aka-mascas/diff

--
Ticket URL: <https://developer.pidgin.im/ticket/16697#comment:6>
Pidgin <https://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
[hidden email]
https://pidgin.im/cgi-bin/mailman/listinfo/tracker