#17061: libpurple: hmac() conflicts with NetBSD's libc hmac()

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

#17061: libpurple: hmac() conflicts with NetBSD's libc hmac()

Pidgin
#17061: libpurple: hmac() conflicts with NetBSD's libc hmac()
---------------------+-----------------------
 Reporter:  _wiz_    |      Owner:
     Type:  patch    |     Status:  new
Milestone:           |  Component:  libpurple
  Version:  3.0.0hg  |   Keywords:
---------------------+-----------------------
 libpurple/protocols/jabber/auth_scram.c includes a function called hmac()
 (latest release and mercurial from today).
 NetBSD (since a short while) has a hmac() function in its libc, with a
 different calling convention, which breaks the build, see
 http://netbsd.gw.com/cgi-bin/man-cgi?hmac++NetBSD-current

--
Ticket URL: <https://developer.pidgin.im/ticket/17061>
Pidgin <https://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
[hidden email]
https://pidgin.im/cgi-bin/mailman/listinfo/tracker
Reply | Threaded
Open this post in threaded view
|

Re: #17061: libpurple: hmac() conflicts with NetBSD's libc hmac()

Pidgin
#17061: libpurple: hmac() conflicts with NetBSD's libc hmac()
---------------------+------------------------
 Reporter:  _wiz_    |       Owner:
     Type:  patch    |      Status:  new
Milestone:  3.0.0    |   Component:  libpurple
  Version:  3.0.0hg  |  Resolution:
 Keywords:           |
---------------------+------------------------
Changes (by Robby):

 * milestone:   => 3.0.0


--
Ticket URL: <https://developer.pidgin.im/ticket/17061#comment:1>
Pidgin <https://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
[hidden email]
https://pidgin.im/cgi-bin/mailman/listinfo/tracker
Reply | Threaded
Open this post in threaded view
|

Re: #17061: libpurple: hmac() conflicts with NetBSD's libc hmac()

Pidgin
In reply to this post by Pidgin
#17061: libpurple: hmac() conflicts with NetBSD's libc hmac()
---------------------+------------------------
 Reporter:  _wiz_    |       Owner:
     Type:  patch    |      Status:  closed
Milestone:  2.10.13  |   Component:  libpurple
  Version:  3.0.0hg  |  Resolution:  fixed
 Keywords:           |
---------------------+------------------------
Changes (by dx <dx@…>):

 * status:  new => closed
 * resolution:   => fixed
 * milestone:  3.0.0 => 2.10.13


Comment:

 (In [1e7a57174d26]):[[BR]]
 jabber/auth_scram: prefix the names of the 'hmac' and 'hash' functions

 Trac ticket #17061 says that netbsd added a function called hmac to its
 libc.

 These are private (static) functions so it's safe to rename them. Also
 renaming
 the hash function just in case.

 Fixes #17061

--
Ticket URL: <https://developer.pidgin.im/ticket/17061#comment:2>
Pidgin <https://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
[hidden email]
https://pidgin.im/cgi-bin/mailman/listinfo/tracker
Reply | Threaded
Open this post in threaded view
|

Re: #17061: libpurple: hmac() conflicts with NetBSD's libc hmac()

Pidgin
In reply to this post by Pidgin
#17061: libpurple: hmac() conflicts with NetBSD's libc hmac()
---------------------+------------------------
 Reporter:  _wiz_    |       Owner:
     Type:  patch    |      Status:  closed
Milestone:  2.10.13  |   Component:  libpurple
  Version:  3.0.0hg  |  Resolution:  fixed
 Keywords:           |
---------------------+------------------------

Comment (by Robby):

 Thanks for the report, _wiz_! Another 3.0 ticket down… :-)

--
Ticket URL: <https://developer.pidgin.im/ticket/17061#comment:3>
Pidgin <https://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
[hidden email]
https://pidgin.im/cgi-bin/mailman/listinfo/tracker
Reply | Threaded
Open this post in threaded view
|

Re: #17061: libpurple: hmac() conflicts with NetBSD's libc hmac()

Pidgin
In reply to this post by Pidgin
#17061: libpurple: hmac() conflicts with NetBSD's libc hmac()
---------------------+------------------------
 Reporter:  _wiz_    |       Owner:
     Type:  patch    |      Status:  closed
Milestone:  2.12.1   |   Component:  libpurple
  Version:  3.0.0hg  |  Resolution:  fixed
 Keywords:           |
---------------------+------------------------
Changes (by Robby):

 * milestone:  2.10.13 => 2.12.1


Comment:

 Post-commit hook needs work.

--
Ticket URL: <https://developer.pidgin.im/ticket/17061#comment:4>
Pidgin <https://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
[hidden email]
https://pidgin.im/cgi-bin/mailman/listinfo/tracker