Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Submitted By: Sadrul Habib Chowdhury (sadrul)
Assigned to: Nobody/Anonymous (nobody)
Summary: Conversation: confirm before close unread tabs
This patch requests confirmation before closing tabs
with unread messages (from `Close other tabs' or `close
It also makes the gtkconv the handle for the notify/
request dialogs, which I think makes more sense.
The existing confirmation dialog comes up only when you
close the whole window, but doesn't popup when you do `Close
other tabs' or `close this tab', or [accidentally] click on
the [x]. And the existing dialog is modal.
I have attached a new patch which removes the existing
dialog, and uses the new dialogs. The result is, a popup
will appear for each tab with unread messages, and the tabs
with no unread messages will be closed. This behaviour is
different from the existing behaviour (currently it doesn't
close any tab).
I am unable to decide whether this would confuse users.
Comment By: Richard Laager (rlaager)
Date: 2006-02-06 20:33
Logged In: YES
I accepted the gtkconv handle portion of this patch.
As for the confirmation dialog.... We already have code to
build a confirmation window when you try to close the
window and one of the tabs has unread messages. I'd like to
see this new dialog be more connsisten with that. The code
should probably be reworked a bit so there isn't
duplication. Let me know if that sounds stupid.